Merge pull request #3 from sg00dwin/cdcabrera-issue-envfrom-link

Move 'view details' link into it's own container that can wrap at mobile
openshift · Oct 12, 2017 · fc1c603 · fc1c603
2 parents 65b96ce + b53fb7f
commit fc1c603
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/app/styles/_kve.less b/app/styles/_kve.less
@@ -118,6 +118,7 @@
   .key-value-editor-entry,
   .environment-from-entry {
     display: table;
+    margin-bottom: 15px;
     padding-right: (@as-sortable-item-button-width * 2);
     position: relative;
     table-layout: fixed;
@@ -127,11 +128,12 @@
         float: left;
         padding-right: 5px;
         position: relative;
-        width: 50%;
+        width: auto;
       }
     }
     .environment-from-input {
       float: left;
+      margin-bottom: 0;
       padding-right: 5px;
       width: 100%;
       @media(min-width: @screen-md-min) {
@@ -144,6 +146,13 @@
       }
     }
   }
+  .environment-from-entry {
+    .environment-from-view-details {
+      float: left;
+      line-height: 1;
+      padding: 6px 0 0;
+    }
+  }
 
   .key-value-editor-input .ui-select {
     @media(min-width: @screen-md-min) {
@@ -163,6 +172,7 @@
 .key-value-editor .key-value-editor-input,
 .key-value-editor-header {
   float: left;
+  margin-bottom: 0;
   padding-right: 5px;
   width: 50%;
 }

diff --git a/app/views/directives/edit-environment-from.html b/app/views/directives/edit-environment-from.html
@@ -67,11 +67,12 @@
           role="button"
           aria-label="Delete row"
           ng-click="$ctrl.deleteEntry($index, 1)"></a>
+      </div>
+      <div class="environment-from-view-details">
         <a
           ng-if="entry.selectedEnvFrom"
           href=""
-          ng-click="$ctrl.viewOverlayPanel(entry.selectedEnvFrom)"
-          class="pficon">View Details</a>
+          ng-click="$ctrl.viewOverlayPanel(entry.selectedEnvFrom)">View Details</a>
       </div>
     </div>