import yaml modal has an unnecessary scrollbar when launched from landing page

[ncameronbritt]

When launched from the landing page, the Import YAML modal has a scrollbar, but not when launched from within a project.

Landing page:

Project:

[ncameronbritt]

Sorry, copied the wrong image the first time.

[rhamilto]

This is occurring because of the addition of the "Add to project" dropdown. I'm assuming we don't want to increase the max-height of the modal for this one use case.

And note: if user chooses to "Create Project" from the "Add to Project" dropdown, additional fields appear.

[rhamilto]

An alternate approach to increasing the max-height of the modal would be to reduce the height of the editor when on the landing page. But we'll still have the "Create Project" issue.

[spadgett]

I think Jessica set the editor height based on the dialog height before we added the select project dropdown. I'm OK with either fix. It does seem like the dialog is a little short to me, though.

I'm less worried about "Create Project."

[ncameronbritt]

@rhamilto @spadgett I glossed over the project picker. I'm not sure there's a real issue here. I mean, if the modal has a max height, then at some point it will need to scroll.

[spadgett]

I agree except we're tying to size the editor to exactly fit, but not doing it right in this instance.

[rhamilto]

I like the latter option as it doesn't require futzing with the modal max-height and eliminates double scrollbars.

Yea

Nay

I will PR the Yea if y'all are good with it.

[ncameronbritt]

If @spadgett is good with it, I am too.

[spadgett]

Works for me, thanks @rhamilto