EnvFrom in the Env Editors Interface Issues

[cdcabrera]

EnvFrom

• The drag and drop handle associated with updating the sequence order of EnvFrom values doesn't remain hidden when there is a single entry
• Missing link for viewing Config Maps and Secret details. It would be helpful to see these details at the time of adding these bulk additions.
• Minor copy revisit
• Minor CSS color highlight and contrast issue on disabled selected values. The color needs adjustment, either the copy or the background... or both.
• Prefixes for EnvFrom values, see issue Need to handle envFrom prefix #2362

EnvFrom & Variables

• Random refresh issue where a background process appears to run and reset some of the drop-downs causing them to collapse even though the user has them open
  • This refresh goes towards a larger issue around how watches on the parent view are providing updates, which also happens to affect the setting of individual environment values.
• On saving, dependent on background processes, there appears to be a random flash of a hidden form. This also appears to happen when saving environment variables.

[cdcabrera]

@sg00dwin

As discussed the initial fix around removing the disabled and active classes works.

However there appears to be a coincidental case when those 2 classes will still appear, still working on it from the JS side.

As a general heads up...

It's a case where a user has:

• selected the "first entry" in the Config Map and Secrets list,
• then goes to add a second one
• the drop down list goes ahead and highlights the first entry which just so happens to be disabled (at least, that's how it's appearing on my local)

Attached a Gif

[cdcabrera]

@beanh66 @spadgett in process for completing some of the copy updates referenced around #2198 , wanted to make sure understood correctly about the sorting between Config Maps and Secrets.

Right now we're seeing the opposite of what's referenced in the comments regarding the sort around the select lists. Trying to figure out if there are any other factors at play, if you could post a screen capture that would help out.

[ ...noticed the links say "Config Map or Secret" but in the actual dropdown the secrets are listed first so we should be consistent... ]

The closest we could get to seeing something similar was when the select list displays at the bottom of the page:

[beanh66]

@cdcabrera Maybe I'm just running an old version! What you have looks great :)

[cdcabrera]

@beanh66

Attached below for the reveal secret piece...

@spadgett

[beanh66]

@cdcabrera Looks good, just feels like we may want a little more space between Value Details and Reveal Secret. Even just 5-10px would help. For cases where the revealed values are much longer, would those values wrap and the modal scroll as needed?

[jeff-phillips-18]

@beanh66 Should this look more like the config and bind parameters?

[jeff-phillips-18]

Really weird to me to have the hide/reveal action link in the title area. Shouldn't the title include the name of the secret rather than "Value Details" ?

[beanh66]

@jeff-phillips-18 Good point since it's a modal, that is kinda odd to have actions in the title bar. I don't think we need the secret name in the title bar but it actually would be more consistent to have the Reveal Secret link next to the secret name. @cdcabrera

[cdcabrera]

@beanh66 can move the Reveal Secret link no problem.

[beanh66]

@cdcabrera The link a user clicked to get this dialog would say "View Details," correct? Shouldn't the reveal link say "Reveal Values"? @spadgett any thoughts?

@jeff-phillips-18 makes a good point about the "Value Details" not meaning much. Would it be possible to have the modal title be "Secret Details" if a secret and "Config Map Details" if a config map?

[beanh66]

[cdcabrera]

@beanh66 funny you should mention the title changing @spadgett and myself talked about doing that, it is easily done.

As for the navigation to get the modal to pop up... you are correct, it's the "View Details". Changing the reveal to something like "Reveal [Values]" does sound better to me.

[cdcabrera]

@beanh66 updated the code... can also apply a singular/plural context to "Reveal Value"/"Reveal Values" when only single entries happen.

[cdcabrera]

For the record... EnvFrom updates related to smaller screens, expanding out @sg00dwin

[beanh66]

@cdcabrera Why are there two ? icons once a user initiates an error? Wouldn't there just be a single field level help for the "Prefix" field?

[sg00dwin]

@beanh66 I'm doing some follow up changes from @jennyhaines, so I'll add the valid prefix message to the 'Prefix' label help tooltip and remove the second one so it will look like.

[beanh66]

@sg00dwin perfect, thanks!

[spadgett]

The significant refresh issues have been fixed, and @jennyhaines' style recommendations have been implemented. Closing this issue since all of the concerns have been addressed