Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting wizard title adds a tooltip to the entire dialog #2228

Closed
spadgett opened this issue Oct 6, 2017 · 3 comments
Closed

Setting wizard title adds a tooltip to the entire dialog #2228

spadgett opened this issue Oct 6, 2017 · 3 comments
Assignees
@spadgett
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P3
Milestone
3.7.0

Comments

@spadgett
Copy link
Member

spadgett commented Oct 6, 2017

Since the title attribute is a standard HTML attribute used for tooltips, setting title on the pf-wizard component causes the browser to show a tooltip when you hover the mouse over any part of the dialog. This is especially confusing when you hover over a "Cancel" button and it shows a tooltip like "Create Binding."

One example: https://github.com/openshift/origin-web-console/blob/master/app/views/directives/bind-service.html#L3

But it's now a problem in all of our dialogs. This might need to be fixed upstream in angular-patternfly.

https://github.com/patternfly/angular-patternfly/blob/master/src/wizard/wizard.component.js#L314

cc @jeff-phillips-18 @dtaylor113 @rhamilto
@spadgett spadgett added kind/bug Categorizes issue or PR as related to a bug. priority/P3 labels Oct 6, 2017
@spadgett spadgett added this to the 3.7.0 milestone Oct 6, 2017
@spadgett
Copy link
Member Author

spadgett commented Oct 6, 2017

I see now there's an angular-patternfly issue: patternfly/angular-patternfly#639

This was referenced Oct 19, 2017
Merged
Merged
@spadgett
Copy link
Member Author

Closing as this is now tracked by https://bugzilla.redhat.com/show_bug.cgi?id=1504001

openshift-merge-robot added a commit that referenced this issue Oct 19, 2017
@openshift-merge-robot
Merge pull request #2306 from spadgett/fix-dialog-tooltip
cad0684 
Automatic merge from submit-queue.

Bug 1504001 - Fix tooltip over entire dialog

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1504001
See also #2228
See also openshift/origin-web-catalog#514
@spadgett
Copy link
Member Author

This has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spadgett spadgett

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P3
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
3 participants
@spadgett @jeff-phillips-18 @dtaylor113