Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Membership role filter seems to match items it shouldn't #2260

Closed
spadgett opened this issue Oct 13, 2017 · 0 comments
Closed

Membership role filter seems to match items it shouldn't #2260

spadgett opened this issue Oct 13, 2017 · 0 comments
Assignees
@spadgett
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P2
Milestone
3.7.0

Comments

@spadgett
Copy link
Member

When I type in view I'm seeing things like "edit" and "sar-creator." I don't know why these are being matched.

openshift web console 2017-10-13 06-18-43
@spadgett spadgett added kind/bug Categorizes issue or PR as related to a bug. priority/P2 labels Oct 13, 2017
@spadgett spadgett added this to the 3.7.0 milestone Oct 13, 2017
@spadgett spadgett mentioned this issue Oct 13, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Oct 13, 2017
@openshift-merge-robot
Merge pull request #2265 from spadgett/improve-role-dropdown
4c16ab5 
Automatic merge from submit-queue.

Improve role select when editing membership

* Only match role names to avoid false positives
* Remove unnecessary sort since it's sorted in the controller
* Add a `track by` to the repeat
* Highlight search matches in the dropdown

![openshift web console 2017-10-13 12-06-07](https://user-images.githubusercontent.com/1167259/31555415-eefc47f2-b00e-11e7-8b1d-c0af8e95ccc0.png)

Fixes #2260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spadgett spadgett

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P2
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
2 participants
@benjaminapetersen @spadgett