Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to handle removed plans when updating a service instance. #2316

Closed
jeff-phillips-18 opened this issue Oct 19, 2017 · 1 comment
Closed

Need to handle removed plans when updating a service instance. #2316

jeff-phillips-18 opened this issue Oct 19, 2017 · 1 comment
Assignees
@jeff-phillips-18
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P1
Milestone
3.7.0

Comments

@jeff-phillips-18
Copy link
Member

Plans can be removed but still be the 'plan of record' for a service instance. If the current plans is removed, do not allow modifying plan's parameter values.

Follow on from #2237
@spadgett spadgett added kind/bug Categorizes issue or PR as related to a bug. priority/P1 labels Oct 19, 2017
@spadgett spadgett added this to the 3.7.0 milestone Oct 19, 2017
@spadgett
Copy link
Member

I believe you can still edit parameters for the current service instance plan, even if it's removed. @pmorie ?

@jwforres FYI

@jeff-phillips-18 jeff-phillips-18 mentioned this issue Oct 25, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Oct 25, 2017
@openshift-merge-robot
Merge pull request #2369 from jeff-phillips-18/parameters
bae09d0 
Automatic merge from submit-queue.

Do not allow updating to plans that have been removed

Fixes #2316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeff-phillips-18 jeff-phillips-18

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P1
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
2 participants
@spadgett @jeff-phillips-18