Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overview bind parameters look odd #2323

Closed
spadgett opened this issue Oct 20, 2017 · 2 comments
Closed

Overview bind parameters look odd #2323

spadgett opened this issue Oct 20, 2017 · 2 comments
Assignees
@spadgett
Labels
area/styles kind/bug Categorizes issue or PR as related to a bug. priority/P2
Milestone
3.7.0

Comments

@spadgett
Copy link
Member

The bind parameters are displayed on the overview now. I think this might be unintentional, but it's odd to show bind parameters and not instance parameters. I'd vote just to remove them.

If we keep them, the spacing looks wrong.

screen shot 2017-10-20 at 8 51 17 am

@jwforres @jeff-phillips-18 FYI
@spadgett spadgett added area/styles kind/bug Categorizes issue or PR as related to a bug. priority/P2 labels Oct 20, 2017
@spadgett spadgett added this to the 3.7.0 milestone Oct 20, 2017
@spadgett spadgett self-assigned this Oct 20, 2017
@spadgett
Copy link
Member Author

Similar spacing problems on the provisioned service page:

screen shot 2017-10-20 at 8 58 44 am

@jeff-phillips-18 jeff-phillips-18 mentioned this issue Oct 20, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Oct 23, 2017
@openshift-merge-robot
Merge pull request #2326 from jeff-phillips-18/parameters
d9e3c8a 
Automatic merge from submit-queue.

Do not show binding parameters on the overview page

See #2323
@jeff-phillips-18
Copy link
Member

Fixed by #2326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spadgett spadgett

Labels
area/styles kind/bug Categorizes issue or PR as related to a bug. priority/P2
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
2 participants
@spadgett @jeff-phillips-18