Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy image dialog should not show an error when it can't list secrets #2354

Closed
spadgett opened this issue Oct 23, 2017 · 1 comment
Closed

Deploy image dialog should not show an error when it can't list secrets #2354

spadgett opened this issue Oct 23, 2017 · 1 comment
Assignees
@spadgett
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P2
Milestone
3.7.0

Comments

@spadgett
Copy link
Member

Currently, you see an error toast when the deploy image dialog can't list secrets. It should suppress this error since they're not needed and only there as options for the env value from options.
@spadgett spadgett added kind/bug Categorizes issue or PR as related to a bug. priority/P3 labels Oct 23, 2017
@spadgett spadgett self-assigned this Oct 23, 2017
@jwforres jwforres added this to the 3.7.0 milestone Oct 23, 2017
@spadgett
Copy link
Member Author

@jwforres It looks like DataService is not passing through anything but the message for list failures. I think this runs deeper than just this one error.

@spadgett spadgett mentioned this issue Oct 23, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Oct 24, 2017
@openshift-merge-robot
Merge pull request #2360 from spadgett/list-status
8ba070b 
Automatic merge from submit-queue.

Use correct HTTP status from failed DataService.list

Bumps origin-web-common to 0.0.69

Requires openshift/origin-web-common#236
Fixes #2354
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spadgett spadgett

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/P2
Projects
None yet
Milestone
3.7.0
Development

No branches or pull requests
2 participants
@spadgett @jwforres