Bug 1462067 - Don't set propagationPolicy when deleting pod immediately

[spadgett]

This change removes the propagation policy from delete options when force deleting a pod from the web console. It makes the web console DELETE request consistent with oc delete --now --force (only when delete immediately is checked).

@jwforres WIP because I haven't been able to verify against a pod that is really stuck in terminating. I'm concerned we might have a GC bug with propagation policy foreground and grace period 0.

@derekwaynecarr Do you know how I can purposely get a pod stuck in Terminating state to test this fix?

cc @deads2k

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1462067

[jwforres]

Change LGTM

[jwforres]

We've been trying to avoid making any special exceptions in the console though, so far every weird case we have hit has been a bug with GC.

[spadgett]

If you're trying to force delete something, foreground propagation seems wrong. But this comment worries me:

However console (v3.6.133) doesn't work, it still put pod in Terminating status. Then try again by CLI command and now pod can't be removed.

https://bugzilla.redhat.com/show_bug.cgi?id=1462067#c12

[jwforres]

Agreed this change is OK then and we need to spawn a separate issue for the fact that GC + Terminating can get pods permanently stuck in storage.

[jwforres]

[merge]

[jwforres]

looks like the webdriver start flake [merge]

[spadgett]

Flake

Selenium standalone server started at http://172.18.5.43:37253/wd/hub
ERROR - Unable to start a WebDriver session.

/data/src/github.com/openshift/origin-web-console/node_modules/selenium-webdriver/lib/atoms/error.js:113
  var template = new Error(this.message);
                 ^
UnknownError: Unable to connect to host 127.0.0.1 on port 7055 after 45000 ms. Firefox console output:
Error: cannot open display: :10

[merge]

[spadgett]

Flake #1684

[openshift-bot]

Evaluated for origin web console merge up to 636745e

[openshift-bot]

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1618/) (Base Commit: 1c22134) (PR Branch Commit: 636745e)