Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the hack/verify-dist.sh message #1999

Conversation

benjaminapetersen
Copy link
Contributor

  • currently the verify-dist.sh error message is not printing
  • alternates the order of fail output to ensure message prints
  • adds some color codes to make it easier to find messages when scanning lengthy logs
    • the desire is for this to work in travis

Deliberately breaking the dist to ensure it works in travis.

@spadgett

@benjaminapetersen
Copy link
Contributor Author

#1988 motivating this tweak.

@benjaminapetersen
Copy link
Contributor Author

benjaminapetersen commented Sep 1, 2017

Travis output:

screen shot 2017-09-01 at 3 24 14 pm

screen shot 2017-09-01 at 4 00 57 pm

- currently the verify-dist.sh error message is not printing
- alternates the order of fail output to ensure message prints
- adds some color codes to make it easier to find messages when scanning lengthy logs
	- the desire is for this to work in travis
@spadgett
Copy link
Member

spadgett commented Sep 1, 2017

[merge][severity: lowrisk]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 07faf47

@openshift-bot
Copy link

openshift-bot commented Sep 1, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/98/) (Base Commit: 59d0df1) (PR Branch Commit: 07faf47) (Extended Tests: lowrisk)

@openshift-bot openshift-bot merged commit 5709d8a into openshift:master Sep 1, 2017
@benjaminapetersen benjaminapetersen deleted the bpeterse/verify-dist-fail-message branch September 1, 2017 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants