Fix selected project test flake #2003
Conversation
spadgett
changed the title
|
[test] |
spadgett
force-pushed
the
update-dist
branch
7 times, most recently
from
a9baddc
to
c168f92
Compare
|
@jeff-phillips-18 I think I've fixed the flakes, PTAL |
spadgett
force-pushed
the
update-dist
branch
2 times, most recently
from
8b93611
to
26d175d
Compare
| @@ -45157,34 +45152,7 @@ sSortJUIWrapper: "", | |||
| sSortIcon: "", | |||
| sJUIHeader: "", | |||
| sJUIFooter: "" | |||
| }), function() { | |||
There was a problem hiding this comment.
Does the dist here seem odd?
There was a problem hiding this comment.
Does the dist here seem odd?
The datatables dependency changed.
| @@ -329,8 +329,23 @@ angular.module('openshiftConsole') | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Pulled & ran it to see if I could replicate the bug. Haven't quite figured out how this change fixes the test, but +1 😄
|
Well I've fixed one of two flakes anyway. Investigating the other |
|
[test] |
Avoids a problem where the wrong project can be shown as selected in the project bar dropdown when the project is not returned in `ProjectsService.list`.
spadgett
force-pushed
the
update-dist
branch
from
b8f4b9b
to
cf7a218
Compare
|
Evaluated for origin web console test up to cf7a218 |
|
Origin Web Console Test Results: Running (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/131/) (Base Commit: 5709d8a) (PR Branch Commit: cf7a218) |
|
Origin Web Console Test Results: SUCCESS |
|
[merge] |
|
Evaluated for origin web console merge up to cf7a218 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/108/) (Base Commit: 5709d8a) (PR Branch Commit: cf7a218) |
Closes #2005