Not allowing creation date to wrap to eliminate bug #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminapetersen
approved these changes
Sep 5, 2017
| @@ -19,6 +19,13 @@ | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Fix looks good to me. I have a PR to common that we will need tomorrow anyway, if that makes you feel better about migrating it up.
spadgett
approved these changes
Sep 6, 2017
|
[merge][severity: bug] |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin web console test up to b8b026d |
|
Origin Web Console Test Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/138/) (Base Commit: 2fbc58a) (PR Branch Commit: b8b026d) |
|
[merge][severity: bug] |
|
Evaluated for origin web console merge up to b8b026d |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/123/) (Base Commit: b919687) (PR Branch Commit: b8b026d) (Extended Tests: bug) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes openshift/origin-web-catalog#412
Note: this fix is imperfect in that it only applies to the catalog when in the context of the console. Why? Because the bug also occurs in the console on the projects list page, and I figured it should be fixed in both places. The "proper" fix would be to put these additions in origin-web-common, but that necessitates a release of common, and that seems like a lot of overhead for a "simple" bug. Agree/disagree @spadgett?