Fix excessively large notification blank state message #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
reviewed
Sep 6, 2017
app/styles/_notifications.less
Outdated
| @@ -3,6 +3,9 @@ | |||
| // ----------------------------------------------- | |||
|
|
|||
| notification-drawer-wrapper { | |||
| .blank-state-pf-title { | |||
| font-size: 14px; | |||
There was a problem hiding this comment.
Better to make this relative to the font-size-base variable
There was a problem hiding this comment.
Updated to use:
// app/styles/_variables.less:
@font-size-h4: ceil(@font-size-base * 1.047); // ~14pxworks?
rhamilto
approved these changes
Sep 6, 2017
benjaminapetersen
force-pushed
the
bpeterse/notification-blank-state-message
branch
from
6926da1
to
ef36cf8
Compare
|
[merge][severity: bug] |
spadgett
approved these changes
Sep 6, 2017
jeff-phillips-18
approved these changes
Sep 6, 2017
|
Evaluated for origin web console merge up to ef36cf8 |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin web console test up to ef36cf8 |
|
Origin Web Console Test Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/142/) (Base Commit: e724d33) (PR Branch Commit: ef36cf8) |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/135/) (Base Commit: 8a15031) (PR Branch Commit: ef36cf8) (Extended Tests: bug) |
benjaminapetersen
deleted the
bpeterse/notification-blank-state-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @sg00dwin's update, we prob need to patch the blank state as well to reduce the crazy font size:
fix #2022
A corrective fix will come upstream in angular-patternfly angular-patternfly in the future.
@spadgett @jeff-phillips-18 @sg00dwin