Update notification drawer to use trackByID #2046
Conversation
| @@ -7,7 +7,7 @@ | |||
| heading-include="{{$ctrl.headingInclude}}" | |||
| notification-body-include="{{$ctrl.notificationBodyInclude}}" | |||
| notification-groups="$ctrl.notificationGroups" | |||
| notification-track-field="uid" | |||
| notification-track-field="trackByID" | |||
There was a problem hiding this comment.
Don't you need to set trackByID here for events?
There was a problem hiding this comment.
Yup! looking at that now, I'll have an update in a second.
There was a problem hiding this comment.
I think mapping event.metadata.uid is fine. not sure if it really needs the same format of _.uniqueId('notification-') + Date.now()
There was a problem hiding this comment.
yeah has to be this way with count increments & things.
benjaminapetersen
force-pushed
the
bpetersen/track-by-id
branch
from
c1e7e0f
to
b5cbf48
Compare
|
updated |
|
[merge][severity: bug] |
|
Flake #1685 (not the one we just fixed!) [merge][severity: bug] |
|
Evaluated for origin web console merge up to b5cbf48 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/191/) (Base Commit: 08814ee) (PR Branch Commit: b5cbf48) (Extended Tests: bug) |
Depends on release including PR 180 from origin-web-common.
@spadgett @jeff-phillips-18