Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notification drawer to use trackByID #2046

Merged

Conversation

benjaminapetersen
Copy link
Contributor

Depends on release including PR 180 from origin-web-common.

@spadgett @jeff-phillips-18

@@ -7,7 +7,7 @@
heading-include="{{$ctrl.headingInclude}}"
notification-body-include="{{$ctrl.notificationBodyInclude}}"
notification-groups="$ctrl.notificationGroups"
notification-track-field="uid"
notification-track-field="trackByID"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! looking at that now, I'll have an update in a second.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think mapping event.metadata.uid is fine. not sure if it really needs the same format of _.uniqueId('notification-') + Date.now()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah has to be this way with count increments & things.

@benjaminapetersen
Copy link
Contributor Author

updated

@spadgett
Copy link
Member

[merge][severity: bug]

@spadgett
Copy link
Member

Flake #1685 (not the one we just fixed!)

[merge][severity: bug]

@openshift-bot
Copy link

Evaluated for origin web console merge up to b5cbf48

@openshift-bot
Copy link

openshift-bot commented Sep 13, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/191/) (Base Commit: 08814ee) (PR Branch Commit: b5cbf48) (Extended Tests: bug)

@openshift-bot openshift-bot merged commit 1bb46a9 into openshift:master Sep 13, 2017
@benjaminapetersen benjaminapetersen deleted the bpetersen/track-by-id branch September 13, 2017 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants