Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for project bar visibility #2053

Merged
merged 1 commit into from
Sep 12, 2017

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Sep 12, 2017

Wait for the project bar to become visible before trying to click the "Add to Project" dropdown. It uses ng-show instead of ng-if.

Closes #2016

@spadgett
Copy link
Member Author

[test]

@spadgett
Copy link
Member Author

spadgett commented Sep 12, 2017

1 successful run:

https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/162/

let's try again, [test]

@spadgett
Copy link
Member Author

Last failure was an unrelated flake:

ERROR - Unable to start a WebDriver session.

/data/src/github.com/openshift/origin-web-console/node_modules/selenium-webdriver/lib/atoms/error.js:113
  var template = new Error(this.message);
                 ^
UnknownError: Unable to connect to host 127.0.0.1 on port 7055 after 45000 ms. Firefox console output:
Error: cannot open display: :10

[test]

@spadgett
Copy link
Member Author

@spadgett
Copy link
Member Author

@spadgett
Copy link
Member Author

@benjaminapetersen @jeff-phillips-18 PTAL, I hope this fixes #2016. (3 successful tests without the flake so far.)

@spadgett
Copy link
Member Author

Last test failure was a dist failure. Looks like a dependency might have changed?

Built /dist does not match what is committed, run 'grunt build' and include the results in your commit.

Wait for the project bar to become visible before trying to click the
"Add to Project" dropdown. It uses `ng-show` instead of `ng-if`.
@spadgett
Copy link
Member Author

Updated dist

@openshift-bot
Copy link

Evaluated for origin web console test up to 43b8ef6

@spadgett spadgett changed the title [WIP] Wait for project bar visibility Wait for project bar visibility Sep 12, 2017
@openshift-bot
Copy link

Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/168/) (Base Commit: 39361a1) (PR Branch Commit: 43b8ef6)

@spadgett
Copy link
Member Author

spadgett commented Sep 12, 2017

4 successful test runs without the flake.

[merge][severity: blocker]

@openshift-bot
Copy link

openshift-bot commented Sep 12, 2017

Origin Web Console Merge Results: Waiting: You are in the build queue at position: 1

@openshift-bot
Copy link

Evaluated for origin web console merge up to 43b8ef6

Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants