"Add to Application" for config maps #2094
Conversation
spadgett
force-pushed
the
add-config-map-to-application
branch
from
d06ebd8
to
faadfc7
Compare
spadgett
changed the title
Implement "Add to Application" on the config map page like we've already done for secrets.
spadgett
force-pushed
the
add-config-map-to-application
branch
from
faadfc7
to
6d67cc0
Compare
|
[test] |
|
Evaluated for origin web console test up to 6d67cc0 |
|
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/221/) (Base Commit: 1b695d8) (PR Branch Commit: 6d67cc0) |
|
@jeff-phillips-18 PTAL |
| @@ -58,7 +74,7 @@ <h1 class="contains-actions"> | |||
| <truncate-long-text | |||
| content="value" | |||
| limit="1024" | |||
| newlineLimit="20" | |||
| newline-limit="20" | |||
There was a problem hiding this comment.
This same error occurs at https://github.com/openshift/origin-web-console/blob/master/app/views/browse/config-map.html#L61
Not part of this PR but might be worth fixing here.
There was a problem hiding this comment.
Thanks, looks like that might be the same line as here?
Did a quick search for this, and I don't see any other references. I know @rhamilto fixed one in another place.
|
[merge] |
1 similar comment
|
[merge] |
|
Evaluated for origin web console merge up to 6d67cc0 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/211/) (Base Commit: 690def0) (PR Branch Commit: 6d67cc0) |
Implement "Add to Application" on the config map page like we've already done for secrets. Reusing the component @jeff-phillips-18 added in #2021