Changing overlay layout to a single column #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhamilto
changed the title
rhamilto
changed the title
spadgett
reviewed
Sep 22, 2017
| @@ -0,0 +1,20 @@ | |||
| <div class="order-service-details" ng-if="!$ctrl.selectStep.selected"> | |||
There was a problem hiding this comment.
I don't think the ng-if is needed here because you check ng-if="step.selected" above before including the view.
| <div class="order-service-details" ng-if="!$ctrl.selectStep.selected"> | ||
| <div class="order-service-details-top"> | ||
| <div class="service-icon"> | ||
| <span class="icon {{$ctrl.iconClass}}"></span> |
spadgett
approved these changes
Sep 22, 2017
jeff-phillips-18
approved these changes
Sep 22, 2017
rhamilto
changed the title
|
[merge] |
|
Evaluated for origin web console merge up to e3af4f7 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/249/) (Base Commit: 0ffc72d) (PR Branch Commit: e3af4f7) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/6zsvyyYu
Requires openshift/origin-web-catalog#413