Fix binding ready logic #2154
Merged
Fix binding ready logic #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The binding ready logic was flipped in the service-binding component, so the View Secret link was showing up at the wrong time.
spadgett
commented
Sep 25, 2017
| @@ -46,7 +46,7 @@ | |||
| project-name="{{$ctrl.binding.metadata.namespace}}" | |||
| stay-on-current-page="true"> | |||
| </delete-link> | |||
| <a ng-if="('secrets' | canI : 'get') && !($ctrl.binding | isBindingFailed) && !(binding | isBindingReady)" | |||
| <a ng-if="('secrets' | canI : 'get') && ($ctrl.binding | isBindingReady)" | |||
There was a problem hiding this comment.
@jeff-phillips-18 The failed check isn't necessary because the binding is never ready when the Failed condition is true. (Checked with @pmorie on this a few days ago.)
There was a problem hiding this comment.
Note that the logic before was !(binding | isBindingReady)
jeff-phillips-18
approved these changes
Sep 25, 2017
|
[merge] |
|
@ncameronbritt Is there any reason we don't just make the secret name itself a link instead of having a separate "View Secret" link? I think this might be a hold-over from designs when we had pod presets. |
|
Evaluated for origin web console merge up to 88343c9 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/258/) (Base Commit: 8824fc8) (PR Branch Commit: 88343c9) |
|
That's a holdover from pod presets. Not sure there's any reason not to have
the secret name be the link, and remove the "view secret" action as long as
pod presets are out.
…On Mon, Sep 25, 2017 at 9:03 AM Sam Padgett ***@***.***> wrote:
@ncameronbritt <https://github.com/ncameronbritt> Is there any reason we
don't just make the secret name itself a link instead of having a separate
"View Secret" link? I think this might be a hold-over from designs when we
had pod presets.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2154 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIjxAf56PzxunuOk2hzZnKQNHziCe1-Fks5sl6SGgaJpZM4PinR->
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binding ready logic was flipped in the service-binding component, so the View Secret link was showing up at the wrong time.