Bug 1495460 - Fix build config source namespace #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
force-pushed
the
build-advanced-options
branch
from
4b73da6
to
2de3f83
Compare
jeff-phillips-18
approved these changes
Sep 26, 2017
Correctly set the build config source image namespace when adding a builder using advanced options. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1495460
spadgett
force-pushed
the
build-advanced-options
branch
from
2de3f83
to
e7f6d90
Compare
|
@jeff-phillips-18 After looking at this more, I think it's better to undo the |
jeff-phillips-18
approved these changes
Sep 26, 2017
|
Thanks @jeff-phillips-18 [merge] |
|
Evaluated for origin web console merge up to e7f6d90 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/270/) (Base Commit: ef5746b) (PR Branch Commit: e7f6d90) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly set the build config source image namespace when adding a builder using advanced options.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1495460