Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let users remove an envFrom entry for a deleted secret #2196

Merged

Conversation

spadgett
Copy link
Member

Fixes #2191

Copy link
Contributor

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@spadgett
Copy link
Member Author

spadgett commented Oct 2, 2017

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 1921ad3

@openshift-bot
Copy link

openshift-bot commented Oct 2, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/301/) (Base Commit: 752a6ae) (PR Branch Commit: 1921ad3)

@openshift-bot openshift-bot merged commit 9c144f3 into openshift:master Oct 2, 2017
@spadgett spadgett deleted the remove-envFrom-deleted-secret branch October 2, 2017 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants