Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show "Service Instance" in Other Resources list #2199

Merged
merged 1 commit into from
Oct 5, 2017
Merged

Don't show "Service Instance" in Other Resources list #2199

merged 1 commit into from
Oct 5, 2017

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Oct 2, 2017

Since we have a dedicated page for service instances now, don't show it in the other resources list.

@spadgett
Don't show "Service Instance" in Other Resources list
1bce0af 
Since we have a dedicated page for service instances now, don't show it
in the other resources list.
spadgett
spadgett commented Oct 2, 2017
View reviewed changes
app/scripts/controllers/otherResources.js
case "Route":
case "Secret":
case "Service":
case "ServiceInstance":
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjaminapetersen I sorted the list, but the only change is adding ServiceInstance

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good... this is kind of an awful switch statement huh? 😄

@spadgett
Copy link
Member Author

spadgett commented Oct 2, 2017

[merge]

benjaminapetersen
benjaminapetersen approved these changes Oct 2, 2017
View reviewed changes
app/scripts/controllers/otherResources.js
case "Route":
case "Secret":
case "Service":
case "ServiceInstance":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good... this is kind of an awful switch statement huh? 😄

@spadgett
Copy link
Member Author

spadgett commented Oct 2, 2017

Opened flake #2200

@spadgett
Copy link
Member Author

spadgett commented Oct 2, 2017

[merge]

@spadgett
Copy link
Member Author

spadgett commented Oct 2, 2017

[test]

@spadgett
Copy link
Member Author

spadgett commented Oct 3, 2017

[merge]

@spadgett
Copy link
Member Author

spadgett commented Oct 3, 2017

[test]

1 similar comment
@spadgett
Copy link
Member Author

spadgett commented Oct 4, 2017

[test]

@openshift-bot
Copy link

Evaluated for origin web console test up to 1bce0af

@spadgett
Copy link
Member Author

spadgett commented Oct 4, 2017

[merge]

@openshift-bot
Copy link

Origin Web Console Test Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/277/) (Base Commit: a9de5c9) (PR Branch Commit: 1bce0af)

@spadgett
Copy link
Member Author

spadgett commented Oct 5, 2017

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 1bce0af

@openshift-bot
Copy link

openshift-bot commented Oct 5, 2017 •
edited
Loading

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/312/) (Base Commit: 6ef0e8b) (PR Branch Commit: 1bce0af)

@openshift-bot openshift-bot merged commit 5017f92 into openshift:master Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

@jeff-phillips-18 jeff-phillips-18 jeff-phillips-18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spadgett @openshift-bot @benjaminapetersen @jeff-phillips-18