Temporarily disable some integration tests to unblock queue #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
spadgett
force-pushed
the
disable-tests
branch
from
f562f5b
to
f13a704
Compare
|
[test] |
|
@jeff-phillips-18 @benjaminapetersen Any objection to this? Our merge queue has been broken for several days now. We haven't been able to find a simple fix. I think the right path forward is to update Protractor in #2083, which we need to do anyway. |
benjaminapetersen
approved these changes
Oct 4, 2017
Makefile
Outdated
| @@ -44,5 +44,5 @@ build: install | |||
| test: build | |||
| hack/verify-dist.sh | |||
| hack/test-headless.sh test $(GRUNT_FLAGS) | |||
| hack/test-headless.sh test-integration $(GRUNT_FLAGS) | |||
| -hack/test-headless.sh test-integration $(GRUNT_FLAGS) | |||
There was a problem hiding this comment.
only thought, comment this? the - runs it but wont fail the build?
spadgett
force-pushed
the
disable-tests
branch
from
f13a704
to
19292d6
Compare
|
Evaluated for origin web console test up to 19292d6 |
|
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/283/) (Base Commit: a9de5c9) (PR Branch Commit: 19292d6) |
jeff-phillips-18
approved these changes
Oct 4, 2017
|
[merge] |
|
Origin Web Console Merge Results: Waiting: You are in the build queue at position: 1 |
|
Evaluated for origin web console merge up to 19292d6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the integration tests, but don't fail if only the integration tests fail. See #2200
Merge will still fail on dist differences or unit test failures.