Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preferred version for service bindings #2233

Merged

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Oct 9, 2017

@jeff-phillips-18 FYI, missed this in #2155. PTAL

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 9, 2017
Copy link
Member

@jeff-phillips-18 jeff-phillips-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed it too.

I can go through the rest of console (and catalog?) looking for places not yet using the API service for resources and put up a PR if that's desired.

@spadgett
Copy link
Member Author

spadgett commented Oct 9, 2017

@jeff-phillips-18 Thanks. I found a few places in views that I need to change anyway for the SerivceBinding resource rename. I have them changed locally.

@spadgett spadgett force-pushed the fix-bindings-preferred-version branch from 8f77a1c to 5f9e7da Compare October 9, 2017 14:29
@spadgett
Copy link
Member Author

spadgett commented Oct 9, 2017

[merge]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 5f9e7da

@openshift-bot
Copy link

openshift-bot commented Oct 9, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/325/) (Base Commit: ea7477e) (PR Branch Commit: 5f9e7da)

@openshift-bot openshift-bot merged commit eb33544 into openshift:master Oct 9, 2017
@spadgett spadgett deleted the fix-bindings-preferred-version branch October 9, 2017 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants