Bug 1502914 - Compact empty envFrom entries #2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
Don't include empty `envFrom` entries when updating environment variables. This causes a validation failure. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1502914
spadgett
force-pushed
the
fix-edit-env
branch
from
753195b
to
80b9671
Compare
jwforres
approved these changes
Oct 17, 2017
|
/lgtm |
|
Automatic merge from submit-queue. |
openshift-merge-robot
added a commit
that referenced
this pull request
Oct 17, 2017
Automatic merge from submit-queue. [stage] Bug 1502914 - Compact empty envFrom entries Don't include empty `envFrom` entries when updating environment variables. This causes a validation failure. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1502914 Backport of #2275 to stage branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't include empty
envFromentries when updating environment variables. This causes a validation failure.Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1502914
@jwforres PTAL