Fix issue 2272: Show hidden roles checkbox isnt functioning properly #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
spadgett
reviewed
Oct 17, 2017
app/views/membership.html
Outdated
| <input | ||
| type="checkbox" | ||
| class="toggle-hidden" | ||
| ng-click="showAllRoles($event)" |
There was a problem hiding this comment.
Rename showAllRoles() to toggleRoles()? showAllRoles to me means always show them.
benjaminapetersen
force-pushed
the
issue/2272/hidden-roles-checkbox
branch
from
c171fda
to
f2dd6b2
Compare
openshift-ci-robot
added
size/S
|
@spadgett agree, updated. |
|
/lgtm |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jwforrest @spadgett @sg00dwin
Fix #2272