Membership updates to correct broken layouts when multiple roles assigned #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
benjaminapetersen
approved these changes
Oct 17, 2017
rhamilto
reviewed
Oct 17, 2017
app/styles/_membership.less
Outdated
| @media(min-width: @screen-md-min) { | ||
| padding: 0; | ||
| } | ||
| } | ||
| .add-role-to { |
app/styles/_membership.less
Outdated
| display: none; | ||
| } | ||
| } | ||
| .col-heading .col-add-role h3 { |
app/styles/_membership.less
Outdated
| @media(min-width: @screen-xs-min) { | ||
| max-width: 30%; | ||
| padding: 0 5px 0 0; | ||
| input { |
openshift-merge-robot
added
the
needs-rebase
sg00dwin
force-pushed
the
membership-issue
branch
from
ded8704
to
544fdd5
Compare
|
@rhamilto ready for second look. |
rhamilto
reviewed
Oct 19, 2017
rhamilto
approved these changes
Oct 19, 2017
|
@sg00dwin should be ready, except needs rebase |
…gned. Overall code cleanup Fixes openshift#1219
sg00dwin
force-pushed
the
membership-issue
branch
from
544fdd5
to
07046e5
Compare
openshift-merge-robot
removed
the
needs-rebase
|
@spadgett rebased and ready |
|
@sg00dwin: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
|
I cherry-picked this commit and rebuilt the dist in #2344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current layout breaks are occurring between 768-1200px when there are 3+ roles assigned. And are especially severe in edit mode .
To fix these, roles are stacked and allowed to flex-wrap. And in edit mode from 768-991px, the select field is positioned at the bottom of the stack. Also more space is given to the
col-namecolumn when the vertical nav is collapsed so that long user names don't wrap.Before and after screens below.
Fixes #1219
Before
After
Before
After
Before
After
Before
After
