Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1504511 - Remember template values when clicking back #2322

Conversation

spadgett
Copy link
Member

When editing template parameter values, remember the values when the
user clicks back and then forward again. This will still correctly clear
the values if the user switches templates in the "Select from Project"
dialog.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1504511

@jeff-phillips-18 @jwforres

When editing template parameter values, remember the values when the
user clicks back and then forward again. This will still correctly clear
the values if the user switches templates in the "Select from Project"
dialog.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1504511
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 20, 2017
Copy link
Member

@jeff-phillips-18 jeff-phillips-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if this is an issue with other wizards that have the config forms.

@spadgett
Copy link
Member Author

Sounds like they're OK from the bug:

Ordering image/serviceclass does not have the issue

I'll double check

@spadgett
Copy link
Member Author

The other dialogs remember parameters.

@jwforres
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit 95cdb0c into openshift:master Oct 20, 2017
@spadgett spadgett deleted the process-template-preserve-values branch October 20, 2017 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants