Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alt text for left nav in mini-mode #2359

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Add alt text for left nav in mini-mode #2359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 6 additions & 3 deletions app/views/_sidebar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,17 @@
ng-mouseenter="onMouseEnter(primaryItem)"
ng-mouseleave="onMouseLeave(primaryItem)"
class="list-group-item">
<a ng-if="primaryItem.href" ng-href="{{navURL(primaryItem.href)}}" ng-click="itemClicked(primaryItem)">
<span class="{{primaryItem.iconClass}}"></span> <span class="list-group-item-value">{{primaryItem.label}}</span>
<a
ng-if="primaryItem.href"
ng-href="{{navURL(primaryItem.href)}}"
ng-click="itemClicked(primaryItem)">
<span title="{{primaryItem.label}}" class="{{primaryItem.iconClass}}" aria-hidden="true"></span> <span class="list-group-item-value">{{primaryItem.label}}</span> <span ng-if="nav.collapsed && !isMobile" class="sr-only">{{primaryItem.label}}</span>
</a>
<a
ng-if="!primaryItem.href"
href=""
ng-click="itemClicked(primaryItem)">
<span class="{{primaryItem.iconClass}}"></span> <span class="list-group-item-value">{{primaryItem.label}}</span>
<span title="{{primaryItem.label}}" class="{{primaryItem.iconClass}}" aria-hidden="true"></span> <span class="list-group-item-value">{{primaryItem.label}}</span> <span ng-if="nav.collapsed && !isMobile" class="sr-only">{{primaryItem.label}}</span>
</a>

<!-- Secondary Nav -->
Expand Down
4 changes: 2 additions & 2 deletions dist/scripts/templates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,10 +490,10 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
" 'secondary-nav-item-pf': primaryItem.secondaryNavSections.length\n" +
" }\" ng-if=\"show(primaryItem)\" ng-mouseenter=\"onMouseEnter(primaryItem)\" ng-mouseleave=\"onMouseLeave(primaryItem)\" class=\"list-group-item\">\n" +
"<a ng-if=\"primaryItem.href\" ng-href=\"{{navURL(primaryItem.href)}}\" ng-click=\"itemClicked(primaryItem)\">\n" +
"<span class=\"{{primaryItem.iconClass}}\"></span> <span class=\"list-group-item-value\">{{primaryItem.label}}</span>\n" +
"<span title=\"{{primaryItem.label}}\" class=\"{{primaryItem.iconClass}}\" aria-hidden=\"true\"></span> <span class=\"list-group-item-value\">{{primaryItem.label}}</span> <span ng-if=\"nav.collapsed && !isMobile\" class=\"sr-only\">{{primaryItem.label}}</span>\n" +
"</a>\n" +
"<a ng-if=\"!primaryItem.href\" href=\"\" ng-click=\"itemClicked(primaryItem)\">\n" +
"<span class=\"{{primaryItem.iconClass}}\"></span> <span class=\"list-group-item-value\">{{primaryItem.label}}</span>\n" +
"<span title=\"{{primaryItem.label}}\" class=\"{{primaryItem.iconClass}}\" aria-hidden=\"true\"></span> <span class=\"list-group-item-value\">{{primaryItem.label}}</span> <span ng-if=\"nav.collapsed && !isMobile\" class=\"sr-only\">{{primaryItem.label}}</span>\n" +
"</a>\n" +
"\n" +
"<div ng-if=\"primaryItem.secondaryNavSections.length\" class=\"secondary-nav-item-pf\" ng-class=\"{\n" +
Expand Down