-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change cursor to a pointer when hover over read notification #2370
Conversation
/assign @benjaminapetersen |
I think the fix is to use the default (arrow) cursor when read. Is that what this does? It looks like it makes it a pointer (hand) cursor always. |
So on Master I see what @spadgett mentioned, which is to use the default arrow once it has been read: This PR will always use the pointer: @jwforres can you clarify what you mentioned on this comment? Do we just want to eliminate the hover effect entirely? |
@@ -39,9 +39,9 @@ notification-drawer-wrapper { | |||
} | |||
// the whole block is clickable, need to set pointer on all of these | |||
// for the correct visual |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is quite right, might be that we just want to eliminate the hover (bg blue) as well as return the cursor.
If we switch to the default cursor, I think we'd want to remove the blue hover style as well? But I might have misunderstood @jwforres' comment. I personally don't have a strong preference here. |
weird, i thought i was on master when i checked it... i would at least see what it looks like without the hover color |
So from this comment I was in a impression we want to have to pointer cursor on unread and also read notifications. |
Thinking about it now Im not really sure it would make sense to have the pointer on read notification. If we align on this it would be better to merge @benjaminapetersen PR |
Closing this PR in favor of #2383 |
Cool, think mine is gonna get closed as well. Yay discussions! |
@jwforres PTAL
Closes #2293