Update membership filter to use MEMBERSHIP_WHITELIST in Constants.js #2402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
| @@ -118,13 +118,20 @@ angular | |||
| return _.sortBy(roles, 'metadata.name'); | |||
| }; | |||
|
|
|||
| var filterRoles = function(roles) { | |||
| var filterRoles_PREV = function(roles) { | |||
benjaminapetersen
force-pushed
the
issue/16862/origin/role-whitelist
branch
from
bef57b4
to
c888e06
Compare
jwforres
approved these changes
Oct 30, 2017
|
/lgtm Were we documenting the annotation anywhere? |
openshift-ci-robot
added
kind/bug
spadgett
approved these changes
Oct 30, 2017
|
I'll fish around and see if we have it in docs & if it needs updating. |
|
Updating the test. && we def need to update our unit test reporter as well, ugh. On my todo list. |
benjaminapetersen
force-pushed
the
issue/16862/origin/role-whitelist
branch
from
c888e06
to
2f8e4b8
Compare
openshift-ci-robot
added
size/M
openshift-merge-robot
removed
the
lgtm
|
/lgtm |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving back to using a simple whitelist via origin issue 16862
fixes origin issue 16862
History:
At this point ignoring the annotation
systemOnlyentirely.@jwforres @spadgett @enj