Fix bugzilla 15077030 rolebindings for serviceaccounts #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
|
yup, updating test |
|
Fix looks good to me pending test changes. /kind bug |
openshift-ci-robot
added
the
kind/bug
benjaminapetersen
force-pushed
the
bugzilla/1507730/serviceaccount-rolebinding-double-delete
branch
from
95a6c6b
to
4d6fad0
Compare
openshift-ci-robot
added
size/L
…nt can delete additional rolebindings for serviceaccounts from another namespace
benjaminapetersen
force-pushed
the
bugzilla/1507730/serviceaccount-rolebinding-double-delete
branch
from
4d6fad0
to
b54162a
Compare
| @@ -102,13 +105,61 @@ describe('RoleBindingsService', function() { | |||
| $rootScope.$digest(); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Added new test to cover this use case here.
|
@spadgett tests updated & new test added. |
spadgett
approved these changes
Oct 31, 2017
|
/lgtm |
|
Automatic merge from submit-queue. |
benjaminapetersen
deleted the
bugzilla/1507730/serviceaccount-rolebinding-double-delete
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bugzilla 15077030 where deleting a rolebinding for a serviceaccount can delete additional rolebindings for serviceaccounts from another namespace.
Hopefully will follow-up with some tests soon. Time elapse is def showing some subtle bugs here.