Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't wrap "Clear Filter" text #2439

Merged

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Nov 2, 2017

Before:

iphone x - ios 11 0 2017-11-02 13-04-13

After:

iphone x - ios 11 0 2017-11-02 13-08-36

@jwforres @rhamilto

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 2, 2017
@jwforres
Copy link
Member

jwforres commented Nov 2, 2017

something is wrong with the line height, those two lines of text are too close together

@spadgett
Copy link
Member Author

spadgett commented Nov 2, 2017

something is wrong with the line height, those two lines of text are too close together

This is using the normal h2 style. Seems to be the line-height: 1.1 rule on headers coming from Bootstrap.

@jwforres
Copy link
Member

jwforres commented Nov 2, 2017

We adjust the bootstrap header sizes in our variables, maybe we screwed up the line heights

@rhamilto
Copy link
Member

rhamilto commented Nov 2, 2017

We have many instances of "Clear Filter" now (browse pages). We should probably change them all?

@jwforres
Copy link
Member

jwforres commented Nov 2, 2017

mucking with header line heights is risky at this point

this change can go in as is since it is low risk
/lgtm
/kind bug

@spadgett
Copy link
Member Author

spadgett commented Nov 2, 2017

We have many instances of "Clear Filter" now (browse pages). We should probably change them all?

Updated the others as well.

@spadgett
Copy link
Member Author

spadgett commented Nov 3, 2017

/test

@spadgett
Copy link
Member Author

spadgett commented Nov 3, 2017

@jwforres another look since I added the class to other instances?

@jwforres
Copy link
Member

jwforres commented Nov 3, 2017

/lgtm
/kind bug

@openshift-ci-robot openshift-ci-robot added kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. labels Nov 3, 2017
@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit bea6783 into openshift:master Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants