-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table Empty States V2 #497
Conversation
-Routes -Builds -Deployments -Events -Images -Other Resources -Pods -Services -Storage
@MarkDeMaria I think we should add in an "Add to Project" button for things that don't have create forms. Here is an example from the pipelines page: https://github.com/openshift/origin-web-console/blob/master/app/views/pipelines.html#L22-L38 Can you try this message on one page and post a screenshot of how it looks?
|
For reference, we explored adding buttons to pages that don't have them. |
I prefer it with the button, although i wouldn't say no pods... twice. One h2 with the sentence should be enough |
Origin Web Console Action Required: Pull request cannot be automatically merged, please rebase your branch from latest HEAD and push again |
@ajacobs21e, could you offer some design input on this PR? Currently, empty state tables look like this. If we have an option to create/add something, like a route, we put the button in the top right. However, I believe Routes are the only component that allows additions. This is the updated empty state. Note the 'Add' buttons placement is the same. For pages that cannot be added, @spadgett is suggesting that we add a 'Add to Project' button that would simply go to the 'Add to Project' page, not a page specific to say, creating pods or some specific component. What are your thoughts? Thanks! |
Is there any benefit to showing the table column headers for an empty state? If not, should we switch to the empty state pattern for all empty tables? On Thu, Sep 15, 2016 at 7:38 PM, Mark DeMaria notifications@github.com
Allie Jacobs calendar |
@ajacobs21e I have several concerns/questions if we were going to use the
Those points aside I believe there is history in this PR as to other On Fri, Sep 16, 2016 at 6:45 AM, Allie Jacobs notifications@github.com
|
We added the original empty state messages before the Patternfly empty state pattern existed. If we use the Patternfly style, we should use it everywhere. But we've had some trouble making the Patternfly style fit in some places, in particular where the entire page isn't blank, only a smaller area. |
Sam, can you list some pages that are using the old empty state that don't work well with the PF state? |
We have empty state messages in a dozen files. I'd rather not mix styles.
We'd need to check how the Patternfly styles look in the debug terminal modal, the build trends chart, log viewer, metrics page, and monitoring page (which includes the empty state message inside expanded list view rows in some cases). If we switch, I'd like to switch everywhere and address the concerns that @jwforres raises: #497 (comment) Note that our existing styles are pretty close to Patternfly without the hospital icon and outer border. |
these responses got lost while I was traveling, sorry!
If there's no helpful text there's no need to add it. It could be text explaining why there are no results. Is it because the user hasn't added anything to their project? Or is it because they have a source with no route (for example)? Or is there a problem?
If the prompt is to add something, the add icon makes sense.
Are we able to know that the reason there are zero pods because you haven't added anything to your project yet, and therefore "Add to Project" would be the appropriate action here? |
I prefer the existing console empty-state-message design over the empty table. And browse/pipelines [1] is now an outlier because it features the empty-state-message design, but the other browse pages do not (we've another outlier in quota [2], but it's a special one-off). I think we should pick up the work in this PR (and add new pages like stateful sets). @jwforres, @spadgett, what do you think? If we're not going to switch, we should at least close this PR and #109. |
Replaced by #2259 |
Automatic merge from submit-queue. Replacing empty tables with empty state message Fixes #109 Replaces #497 HACK DAY! Before: ![127 0 0 1-8443-console-project-my-project-dc-browse-deployments](https://user-images.githubusercontent.com/895728/31518381-10aab73c-af6d-11e7-81e0-a650c802b9d7.png) ![127 0 0 1-8443-console-project-my-project-dc-browse-deployments 1](https://user-images.githubusercontent.com/895728/31518396-19db6d7e-af6d-11e7-8c53-949714425d25.png) After: ![localhost-9000-dev-console-project-my-project-empty-quota](https://user-images.githubusercontent.com/895728/31667665-20f0674a-b31e-11e7-8e83-8b0a047220ba.png) ![localhost-9000-dev-console-project-my-project-delete-browse-config-maps-labelfilter 7b 22matchexpressions 22- 5b 7b 22key 22- 22foo 22 22operator 22- 22exists 22 22values 22- 5b 5d 7d 5d 7d](https://user-images.githubusercontent.com/895728/31666705-2eb4f31c-b31b-11e7-98fe-96d86d643a2a.png)
Fixes openshift#109 Replaces openshift#497 HACK DAY!
Fixes openshift#109 Replaces openshift#497 HACK DAY!
@jwforres @benjaminapetersen
Fixes #109
Previous PR #125
Replaces empty states for:
-Routes
-Builds, Build Summary, Build Log
-Deployments
-Events
-Images
-Other Resources
-Pods
-Services
-Storage