apps: ignore name field in template spec

openshift · Oct 5, 2017 · 1ec84c3 · 1ec84c3
1 parent 0e6fb69
commit 1ec84c3
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/pkg/apps/util/util.go b/pkg/apps/util/util.go
@@ -396,6 +396,12 @@ func HasUpdatedImages(dc *deployapi.DeploymentConfig, rc *v1.ReplicationControll
 // comparing replication controller template with deployment config template.
 func filterOutTemplateAnnotationsAndLabels(in *v1.PodTemplateSpec) *v1.PodTemplateSpec {
 	out := *in
+	// TODO: Some templates and new-app sets the 'name' for the template
+	// PodTemplateSpec, however we don't copy it when we creating the deployment.
+	// That results to endless rollouts as the config change sees that as a change
+	// in DC. Unfortunatelly copying the name into RC will cause mass redeployment
+	// for all existing deployments with 'name'.
+	out.Name = ""
 	out.Annotations = map[string]string{}
 	out.Labels = map[string]string{}
 	if in.Annotations != nil {