-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #14910 from mfojtik/remove-generic-trigger
Automatic merge from submit-queue. deploy: remove generic deployment trigger controller Make main deployment config controller trigger rollouts on config changes and image changes. This replaces the generictrigger controller which was calling instantiate to trigger rollouts, but we don't want to call instantiate from a controller. This also handles the logic of initial deployment rollouts (with ICT/without ICT/...). The image change trigger is now delegated to @smarterclayton trigger controller so we only observe an image change which we treat differently from a config change. This should be fully backward compatible with old logic.
- Loading branch information
Showing
14 changed files
with
290 additions
and
756 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81 changes: 0 additions & 81 deletions
81
pkg/apps/controller/generictrigger/deploy_generictrigger_controller.go
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.