Skip to content

Commit

Permalink
Merge pull request #1451 from ironcladlou/post-deployment-hook-proposal
Browse files Browse the repository at this point in the history
Merged by openshift-bot
  • Loading branch information
OpenShift Bot committed Mar 31, 2015
2 parents 05a1663 + 02b88ec commit 5103961
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions docs/proposals/post-deployment-hooks.md
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,22 @@ const (
)
```

#### Validations related to hooks

Initially, valid values for `Lifecycle.Post.FailurePolicy` will be `Retry` and `Continue`. This may change in the future if deployments can be safely rolled back automatically.

TODO: `ExecNewPodAction.ContainerName`

1. Could reject container names that aren't defined in the deploymentConfig.


#### Hook and deployment status relationship

The status of a deployment hook is distinct from the status of the deployment iteself. The deployment status may be updated in response to a change in hook status.

1. The `Pre` hook executes while the deployment has a `New` status, and the hook will have a terminal status prior to the deployment transitioning past `New`.
2. The `Post` hook executes while the deployment has a `Running` status, and the hook will have a terminal status prior to the deployment transitioning past `Running`.


### Example: Rails migration

Expand Down

0 comments on commit 5103961

Please sign in to comment.