Skip to content

Commit

Permalink
UPSTREAM: 52168: Fix incorrect status msg in podautoscaler
Browse files Browse the repository at this point in the history
Fix #49256

When `ScalingLimited = true` for the `hpa`, there is an accompanying
status message, describing why scaling is limited. Previously if the desired
replica count was 0, and spec.minReplicas > 0, the status message
indicated "the desired replica count was less than the min replica
count". This was particularly confusing when `spec.MinReplicas = 1`. If
there was no `spec.minReplicas`, then the status message indicated "the
desired replica count was zero" which is more informative.

Update the calculation of status message so that if the desired replica
count is 0, we always display the clearer "the desired replica count was
zero" status message, even if spec.minReplicas > 0.

Signed-off-by: mattjmcnaughton <mattjmcnaughton@gmail.com>
  • Loading branch information
mattjmcnaughton authored and DirectXMan12 committed Oct 3, 2017
1 parent 1ede896 commit 6294127
Showing 1 changed file with 8 additions and 1 deletion.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 6294127

Please sign in to comment.