Drop authorizer wrapper

The openshift authorizer was wrapping kube authorizer only to generate Forbidden messages, but upstream already generate similar messages and we cannot intercept and change those. So let's just stop duplicating errors and use the upstream authorizer and error messages as is. Signed-off-by: Simo Sorce <simo@redhat.com>
openshift · Aug 6, 2018 · 70b54e7 · 70b54e7
1 parent fcf6cae
commit 70b54e7
Show file tree

Hide file tree

Showing 14 changed files with 40 additions and 450 deletions.
diff --git a/pkg/authorization/authorizer/authorizer.go b/pkg/authorization/authorizer/authorizer.go
diff --git a/pkg/authorization/authorizer/browsersafe/authorizer_test.go b/pkg/authorization/authorizer/browsersafe/authorizer_test.go
@@ -51,7 +51,7 @@ func TestBrowserSafeAuthorizer(t *testing.T) {
 		safeAuthorizer := NewBrowserSafeAuthorizer(delegateAuthorizer, "system:authenticated")
 
 		authorized, reason, err := safeAuthorizer.Authorize(tc.attributes)
-		if authorized == authorizer.DecisionAllow || len(reason) != 0 || err != nil {
+		if authorized == authorizer.DecisionAllow || err != nil {
 			t.Errorf("%s: unexpected output: %v %s %v", name, authorized, reason, err)
 			continue
 		}

diff --git a/pkg/authorization/authorizer/interfaces.go b/pkg/authorization/authorizer/interfaces.go
diff --git a/pkg/authorization/authorizer/messages.go b/pkg/authorization/authorizer/messages.go