ensure builder labels override with proper priority

openshift · Oct 5, 2017 · 757d5ab · 757d5ab
1 parent 4b59312
commit 757d5ab
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 1 deletion.
diff --git a/test/extended/builds/labels.go b/test/extended/builds/labels.go
@@ -113,6 +113,11 @@ func ExpectOpenShiftLabels(labels map[string]string) error {
 			return fmt.Errorf("Built image doesn't contain proper Docker image labels. Missing %q label", label)
 		}
 	}
-
+	if labels["io.k8s.display-name"] != "overridden" {
+		return fmt.Errorc("Existing label was not overridden with user specified value: %s=%s", labels["io.k8s.display-name"], labels["overridden"])
+	}
+	if labels["io.openshift.builder-version"] != "overridden2" {
+		return fmt.Errorc("System generated label was not overridden with user specified value: %s=%s", labels["io.openshift.builder-version"], labels["overridden2"])
+	}
 	return nil
 }
diff --git a/test/extended/testdata/bindata.go b/test/extended/testdata/bindata.go
diff --git a/test/extended/testdata/test-docker-build.json b/test/extended/testdata/test-docker-build.json
@@ -34,6 +34,14 @@
         {
           "name": "user-specified-label",
           "value": "arbitrary-value"
+        },
+        {
+          "name": "io.k8s.display-name",
+          "value": "overridden"
+        },
+        {
+          "name": "io.openshift.build.commit.author",
+          "value": "overridden2"
         }
       ]
     }

diff --git a/test/extended/testdata/test-s2i-build.json b/test/extended/testdata/test-s2i-build.json
@@ -40,6 +40,14 @@
         {
           "name": "user-specified-label",
           "value": "arbitrary-value"
+        },
+        {
+          "name": "io.k8s.display-name",
+          "value": "overridden"
+        },
+        {
+          "name": "io.openshift.build.commit.author",
+          "value": "overridden2"
         }
       ]
     }