Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router path parameters broken in 1.5 #13862

Closed
andrewklau opened this issue Apr 22, 2017 · 11 comments
Closed

Router path parameters broken in 1.5 #13862

andrewklau opened this issue Apr 22, 2017 · 11 comments
Assignees
Labels
component/routing kind/bug Categorizes issue or PR as related to a bug. priority/P1

Comments

@andrewklau
Copy link
Contributor

Routes that are created with a path / are now only responding to traffic in / and not any subsequent paths

ie.
Route: example.com
Path: /

example.com --> OK
example.com/test --> NOT OK

The web console has / as a suggested value
This was not the same behaviour in 1.4.1

Version

v1.5.0

@mignev
Copy link

mignev commented Apr 22, 2017

👍

@markjacksonfishing
Copy link

Dumb question maybe but did we not skip v1.5.0 in favor of v1.5.1 due to a security vulnerability?

@andrewklau
Copy link
Contributor Author

I don't know about that, but this above will definitely be breaking apps for some users that upgrade.

@0xmichalis
Copy link
Contributor

@knobunc

@smarterclayton
Copy link
Contributor

@liggitt has investigated

@liggitt
Copy link
Contributor

liggitt commented Apr 24, 2017

Dumb question maybe but did we not skip v1.5.0 in favor of v1.5.1 due to a security vulnerability?

you may be thinking of kube 1.5.0. OpenShift 1.5.0 is based on kube 1.5.2

@liggitt
Copy link
Contributor

liggitt commented Apr 24, 2017

fixed in #13867, will cherry-pick to release-1.5 branch

@pilhuhn
Copy link

pilhuhn commented Apr 24, 2017

That would explain a thing or two ...

@pweil- pweil- added the kind/bug Categorizes issue or PR as related to a bug. label Apr 24, 2017
@liggitt
Copy link
Contributor

liggitt commented Apr 27, 2017

1.5 pick in #13923

@andrewklau
Copy link
Contributor Author

Will there be a release for this fix?

@coolbrg
Copy link
Contributor

coolbrg commented May 17, 2017

@andrewklau , released with 1.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/routing kind/bug Categorizes issue or PR as related to a bug. priority/P1
Projects
None yet
Development

No branches or pull requests

10 participants