-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match subpaths correctly when path contains trailing slash #13867
Conversation
will open cherry picks once reviewed |
name: "subpath with trailing slash", | ||
hostname: "example.com", | ||
path: "/sub/", | ||
wildcard: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wildcard test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
[test] |
lgtm [test] |
Evaluated for origin test up to 2f3e6df |
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/898/) (Base Commit: 53a4d1b) |
[merge] post rebase, can you backport to 1.5 and I'll cut a release? |
Evaluated for origin merge up to 2f3e6df |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/481/) (Base Commit: ecd4f14) (Image: devenv-rhel7_6183) |
Tracked by bug https://bugzilla.redhat.com/show_bug.cgi?id=1448944 |
Fixes #13862
"/"
and""
behave identically/
, omit/
from the subpath regex