Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match subpaths correctly when path contains trailing slash #13867

Merged
merged 1 commit into from
Apr 27, 2017
Merged

Match subpaths correctly when path contains trailing slash #13867

merged 1 commit into from
Apr 27, 2017

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Apr 24, 2017

Fixes #13862

  • Make paths of "/" and "" behave identically
  • If the path specified in a route ends with a /, omit / from the subpath regex

@liggitt
Copy link
Contributor Author

liggitt commented Apr 24, 2017

will open cherry picks once reviewed

name: "subpath with trailing slash",
hostname: "example.com",
path: "/sub/",
wildcard: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wildcard test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@liggitt
Copy link
Contributor Author

liggitt commented Apr 24, 2017

[test]

@0xmichalis
Copy link
Contributor

lgtm [test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 2f3e6df

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/898/) (Base Commit: 53a4d1b)

@smarterclayton
Copy link
Contributor

[merge] post rebase, can you backport to 1.5 and I'll cut a release?

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 2f3e6df

@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 27, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/481/) (Base Commit: ecd4f14) (Image: devenv-rhel7_6183)

@openshift-bot openshift-bot merged commit 1fcb67a into openshift:master Apr 27, 2017
@liggitt liggitt deleted the router-subpath-regex branch April 27, 2017 17:26
@knobunc
Copy link
Contributor

knobunc commented May 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants