Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport all 1.7/1.8 apiserver metrics fixes to Origin #16208

Closed
smarterclayton opened this issue Sep 7, 2017 · 1 comment
Closed

Backport all 1.7/1.8 apiserver metrics fixes to Origin #16208

smarterclayton opened this issue Sep 7, 2017 · 1 comment
Assignees
@smarterclayton
Labels
area/reliability component/metrics priority/P1 sig/master

Comments

@smarterclayton
Copy link
Contributor

smarterclayton commented Sep 7, 2017 •
edited

Production monitoring needs the apiserver metrics fixed - we need to ensure all of them are back ported for 3.7 (hopefully asap for online first)

  1. 429 rate limit
  2. 504 timeout handler metrics
  3. WATCH being misreported as LIST
  4. Pod logs being misreported as pod GET
  5. Subresource metrics
  6. Namespace scope and request size latency

Likely also of these need to be back ported together because they touch the same code.

Lack of these metrics made us unable to debug several severe issues.
@smarterclayton smarterclayton self-assigned this Sep 9, 2017
@smarterclayton
Copy link
Contributor Author

Also opened kubernetes/kubernetes#52237

@smarterclayton smarterclayton mentioned this issue Sep 9, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Sep 16, 2017
@openshift-merge-robot
Merge pull request #16266 from smarterclayton/metrics
87f0882 
Automatic merge from submit-queue (batch tested with PRs 16362, 16266)

Backport metrics fixes

Fixes #16208

This needs to be in the next release drop

UPSTREAM: 48583: Record 429 and timeout errors to prometheus
UPSTREAM: 49117: Add apiserver metric for response sizes split by namespace scope
UPSTREAM: 49678: Report non-resource URLs in max-in-flight correctly
UPSTREAM: 49678: Timeout filter returns 504 and an inconsistent error body
UPSTREAM: 50123: Report pod logs as CONNECT in metrics
UPSTREAM: 52237: Add scope to all apiserver metrics and report resource scope
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smarterclayton smarterclayton

Labels
area/reliability component/metrics priority/P1 sig/master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smarterclayton