Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RoleBindingRestriction admission code to use only rbac types and drop any authorizationapi conversion or type #16259

Closed
simo5 opened this issue Sep 8, 2017 · 0 comments
Closed

Update RoleBindingRestriction admission code to use only rbac types and drop any authorizationapi conversion or type #16259

simo5 opened this issue Sep 8, 2017 · 0 comments
Assignees
@simo5
Labels
area/security area/techdebt area/tests component/auth priority/P2 sig/security
Milestone
v3.7

Comments

@simo5
Copy link
Contributor

simo5 commented Sep 8, 2017 •
edited by enj

In #16042 (PR #16163) we moved to handle admission only on the remaining rbac resources.
This is a followup bug to remove the use of conversion function and port the rest of the code (mostly subjectchecker) to use only rbac types. The system group / system user distinction will need to be removed as well.
@enj enj added this to the 3.7.0 milestone Sep 8, 2017
@enj enj assigned simo5 Sep 8, 2017
@enj enj added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 8, 2017
@simo5 simo5 mentioned this issue Sep 11, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Sep 16, 2017
@openshift-merge-robot
Merge pull request #16286 from simo5/subjectcheck
61099d2 
Automatic merge from submit-queue (batch tested with PRs 16384, 16327, 16199, 16286, 16378)

Convert subjectchecker to use rbac.Subject

This also removes any distinction between System and regular User/Groups, as that distinction is gone with RBAC RoleBindings.

Fixes #16032
Fixes #16259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simo5 simo5

Labels
area/security area/techdebt area/tests component/auth priority/P2 sig/security
Projects
None yet
Milestone
v3.7
Development

No branches or pull requests
2 participants
@enj @simo5