Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images don't have size property #16306

Closed
miminar opened this issue Sep 12, 2017 · 4 comments
Closed

Images don't have size property #16306

miminar opened this issue Sep 12, 2017 · 4 comments
Assignees
Labels

Comments

@miminar
Copy link

miminar commented Sep 12, 2017

The image size is not set on images pushed to recent (latest) registry/master.

See the image built with OpenShift builder:

oc describe image sha256:12e63f54fca507b2016d2746dd4747e9a5aa0587204a02efc6d25ba51a311e74
Docker Image:   172.30.30.30:5000/extended-test-limitrange-admission-bn8kz-splls/sized@sha256:12e63f54fca507b2016d2746dd4747e9a5aa0587204a02efc6d25ba51a311e74
Name:           sha256:12e63f54fca507b2016d2746dd4747e9a5aa0587204a02efc6d25ba51a311e74
Created:        About a minute ago
Annotations:    openshift.io/image.managed=true
Image Size:     0 B (first layer 15.09 kB, last binary layer 32 B)
Image Created:  About a minute ago
Author:         <none>
Arch:           amd64
Command:        <none>
Working Dir:    <none>
User:           <none>
Exposes Ports:  <none>
Docker Labels:  io.openshift.build.name=sized-1
                io.openshift.build.namespace=extended-test-limitrange-admission-bn8kz-splls
Environment:    PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
                OPENSHIFT_BUILD_NAME=sized-1
                OPENSHIFT_BUILD_NAMESPACE=extended-test-limitrange-admission-bn8kz-splls

Note the Image Size. Because of that, quota/limits don't work. And our extended tests are failing.

@miminar miminar added component/image component/imageregistry kind/bug Categorizes issue or PR as related to a bug. priority/P1 labels Sep 12, 2017
@miminar miminar self-assigned this Sep 12, 2017
@pweil-
Copy link
Contributor

pweil- commented Sep 12, 2017

@miminar please confirm whether or not this is a regression in 3.6 that was missed in testing. If so let's use a BZ to ensure we get cases and backports

/cc @bparees

@miminar
Copy link
Author

miminar commented Sep 12, 2017

Yes, this is a regression from 3.6. Our unit and integration tests don't cover it. It's covered just by optional extended tests.

@bparees
Copy link
Contributor

bparees commented Sep 12, 2017

it's a regression since 3.6, it wasn't a regression the shipped(broker) in 3.6, right?

So our test coverage is ok, no backports needed, just need to fix it and continue to monitor our extended(optional) tests, for which we will start running a nightly job soon.

@miminar
Copy link
Author

miminar commented Sep 13, 2017

Fix available in #16325

openshift-merge-robot added a commit that referenced this issue Oct 3, 2017
…-schema1

Automatic merge from submit-queue.

Correct missing sizes for manifest schema 1 images

Instead of filling metadata in the image object in the registry, send the manifest and config blobs to the master and let it do the job.

Resolves #16306
Resolves: [bz#1491589](https://bugzilla.redhat.com/show_bug.cgi?id=1491589)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants