Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flake: Router test "address already in use" #16414

Closed
smarterclayton opened this issue Sep 18, 2017 · 7 comments · Fixed by #16982
Closed

flake: Router test "address already in use" #16414

smarterclayton opened this issue Sep 18, 2017 · 7 comments · Fixed by #16982
Assignees
@knobunc
Labels
component/networking kind/test-flake Categorizes issue or PR as related to test flakes. priority/P1 sig/networking

Comments

@smarterclayton
Copy link
Contributor

https://storage.googleapis.com/origin-ci-test/logs/test_branch_origin_end_to_end/424/build-log.txt

=== RUN   TestRouter
--- PASS: TestRouter (11.87s)
	router_test.go:353: TC non-secure: url 0.0.0.0 alias unsecure.example.com protocol http
	router_test.go:353: TC non-secure-path: url 0.0.0.0/test alias unsecure.example.com protocol http
	router_test.go:353: TC preferred-port: url 0.0.0.0 alias pref.port.unsecure.example.com protocol http
	router_test.go:353: TC edge termination: url 0.0.0.0 alias edge.example.com protocol https
	router_test.go:353: TC edge termination path: url 0.0.0.0/test alias edge.example.com protocol https
	router_test.go:353: TC reencrypt: url 0.0.0.0 alias reencrypt.example.com protocol https
	router_test.go:353: TC reencrypt-InsecureEdgePolicy: url 0.0.0.0 alias allow.reencrypt.example.com protocol http
	router_test.go:353: TC reencrypt-destcacert: url 0.0.0.0 alias destcert.reencrypt.example.com protocol https
	router_test.go:353: TC reencrypt path: url 0.0.0.0/test alias reencrypt.example.com protocol https
	router_test.go:353: TC passthrough termination: url 0.0.0.0 alias passthrough.example.com protocol https
	router_test.go:353: TC websocket unsecure: url 0.0.0.0 alias ws.unsecure.example.com protocol ws
	router_test.go:353: TC ws edge termination: url 0.0.0.0 alias ws.edge.example.com protocol wss
	router_test.go:353: TC ws passthrough termination: url 0.0.0.0 alias ws.passthrough.example.com protocol wss
=== RUN   TestRouterPathSpecificity
--- FAIL: TestRouterPathSpecificity (0.00s)
	router_test.go:393: Unable to start http server: listen tcp 172.18.1.71:8080: bind: address already in use
=== RUN   TestRouterDuplications
--- FAIL: TestRouterDuplications (0.00s)
	router_test.go:752: Unable to start http server: listen tcp 172.18.1.71:8080: bind: address already in use
=== RUN   TestRouterStatsPort
--- FAIL: TestRouterStatsPort (0.00s)
	router_test.go:884: Unable to start http server: listen tcp 172.18.1.71:8080: bind: address already in use
=== RUN   TestRouterHealthzEndpoint
--- FAIL: TestRouterHealthzEndpoint (0.00s)
	router_test.go:937: Unable to start http server: listen tcp 172.18.1.71:8080: bind: address already in use
=== RUN   TestRouterServiceUnavailable
--- FAIL: TestRouterServiceUnavailable (0.00s)
	router_test.go:975: Unable to start http server: listen tcp 172.18.1.71:8080: bind: address already in use
=== RUN   TestRouterReloadCoalesce
--- PASS: TestRouterReloadCoalesce (15.78s)
=== RUN   TestRouterBindsPortsAfterSync
--- PASS: TestRouterBindsPortsAfterSync (2.02s)
=== RUN   TestIngressConfiguredRouter
--- PASS: TestIngressConfiguredRouter (3.95s)
FAIL

It looks like the first router test didn't successfully shut something down (like the test server that the router talks to).

@openshift/networking
@smarterclayton smarterclayton added kind/test-flake Categorizes issue or PR as related to test flakes. priority/P2 component/networking sig/networking labels Sep 18, 2017
@smarterclayton
Copy link
Contributor Author

https://openshift-gce-devel.appspot.com/build/origin-ci-test/logs/test_branch_origin_end_to_end/421/

@smarterclayton
Copy link
Contributor Author

https://openshift-gce-devel.appspot.com/build/origin-ci-test/logs/test_branch_origin_end_to_end/419/

@smarterclayton
Copy link
Contributor Author

https://openshift-gce-devel.appspot.com/build/origin-ci-test/logs/test_branch_origin_end_to_end/409/

@jsafrane jsafrane mentioned this issue Sep 19, 2017
Merged
@jsafrane
Copy link
Contributor

https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/16139/test_pull_request_origin_end_to_end/2732/

@knobunc knobunc mentioned this issue Sep 20, 2017
Merged
@jim-minter
Copy link
Contributor

https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/16455/test_pull_request_origin_end_to_end/2848/

@jim-minter jim-minter mentioned this issue Sep 20, 2017
Merged
@knobunc knobunc mentioned this issue Sep 20, 2017
Merged
@smarterclayton
Copy link
Contributor Author

Flaking frequently, increasing priority

@JacobTanenbaum JacobTanenbaum mentioned this issue Sep 28, 2017
Merged
4 tasks
@bparees bparees mentioned this issue Oct 5, 2017
Closed
@bparees
Copy link
Contributor

bparees commented Oct 5, 2017

https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/16700/test_pull_request_origin_end_to_end/3729/

@bparees bparees mentioned this issue Oct 5, 2017
Closed
This was referenced Oct 13, 2017
Merged
Merged
@jim-minter jim-minter mentioned this issue Oct 20, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Oct 21, 2017
@openshift-merge-robot
Merge pull request #16982 from jim-minter/issue16414
64c7fcc 
Automatic merge from submit-queue (batch tested with PRs 16983, 16982).

fix flake: Router test "address already in use"

fixes #16414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knobunc knobunc

Labels
component/networking kind/test-flake Categorizes issue or PR as related to test flakes. priority/P1 sig/networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix flake: Router test "address already in use" jim-minter/origin
5 participants
@jim-minter @smarterclayton @jsafrane @bparees @knobunc