Cluster up should no longer set service_catalog_landing_page to true

[spadgett]

In origin-web-console, we've made the service catalog landing page the default (openshift/origin-web-console#2078). Cluster up should no longer set service_catalog_landing_page to true, and that value will be ignored if set.

https://github.com/openshift/origin/blob/master/pkg/oc/bootstrap/docker/openshift/helper.go#L849

[bparees]

If that's the default now, what happens when we bring up cluster up w/o the service catalog?

[spadgett]

It still uses the new experience, just with no service catalog resources.

[bparees]

if we don't set this, people won't be able to use older versions of the web console w/ the SC. Is there any harm in leaving it set?

[bparees]

(this logic is tied to the oc client binary, not the version of the cluster/webconsole they are deploying)

[spadgett]

No, it will just be ignored.

But I thought it wasn't supported already per #16314 (comment) ?

[spadgett]

I'm OK leaving it as-is.

[bparees]

We dropped 3.6 support. someone on a slightly older 3.7 cluster could still have issues. it's not a big deal, just want to make sure you're aware.

[bparees]

When did the web console start treating this as the default?

[spadgett]

When did the web console start treating this as the default?

About 15 minutes ago :)

[spadgett]

We dropped 3.6 support. someone on a slightly older 3.7 cluster could still have issues. it's not a big deal, just want to make sure you're aware.

OK, then probably no change needed. Closing.