Enable new landing page experience by default #2078
Conversation
|
Let's see how many integration tests fail... [test] |
spadgett
force-pushed
the
enable-new-experience
branch
from
be516ab
to
42b6912
Compare
|
On test failure down... wheee.... 🙁 |
spadgett
force-pushed
the
enable-new-experience
branch
3 times, most recently
from
2d38197
to
44bac16
Compare
|
[test] |
spadgett
force-pushed
the
enable-new-experience
branch
3 times, most recently
from
738e832
to
76c1db6
Compare
|
I think Travis is hanging for all of our PRs right now? |
spadgett
force-pushed
the
enable-new-experience
branch
2 times, most recently
from
d2800a8
to
b012860
Compare
flake #1684 [test] |
spadgett
force-pushed
the
enable-new-experience
branch
from
b012860
to
f8a4fdd
Compare
|
[test] |
spadgett
force-pushed
the
enable-new-experience
branch
from
f8a4fdd
to
128b78d
Compare
|
Evaluated for origin web console test up to 128b78d |
|
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/220/) (Base Commit: 1466f66) (PR Branch Commit: 128b78d) |
spadgett
changed the title
|
Opened #2100 for updating the integration tests. |
| @@ -82,15 +82,21 @@ angular.extend(window.OPENSHIFT_CONSTANTS, { | |||
| // when users navigate away from a page without saving. | |||
| DISABLE_CONFIRM_ON_EXIT: false, | |||
|
|
|||
| // This blacklist hides certain kinds from the "Other Resources" page because they are unpersisted, disallowed for most end users, or not supported by openshift but exist in kubernetes | |||
| // Disable the new landing page and service catalog experience. | |||
There was a problem hiding this comment.
Just curious, how long will we keep this flag? Assuming we won't support the old landing page forever.
There was a problem hiding this comment.
I was thinking we'd remove in 3.8
|
[merge] |
|
Thanks @jeff-phillips-18 and @benjaminapetersen for your reviews |
|
Flake #1684 [merge] |
[merge] |
|
Evaluated for origin web console merge up to 128b78d |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/209/) (Base Commit: 0ce60c1) (PR Branch Commit: 128b78d) |
Use API discovery to see whether the service catalog is enabled. Leaves a
DISABLE_SERVICE_CATALOG_LANDING_PAGEconfig option for now.This PR updates the tests so that they're no longer failing, but the tests still use a few old pages (
/create-projectand/create). We should fix those in a follow-on after #2083 merges.TODO
@jeff-phillips-18 FYI