-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAPI spec marking optional v1.Route fields as required #24060
Comments
This is causing a blocker for using any Helm version |
Now that Helm v3.0.0 has been tagged and released, this bug is preventing anyone using OKD from upgrading to Helm 3. |
There are IMHO more resources with fields that shouldn't be marked as required, for example: "v1.BuildConfig": {
"required": [
"spec",
"status" # <--- ???
], or "v1.BuildConfigSpec": {
"required": [
"triggers",
"strategy",
"nodeSelector" # <--- ???
], |
I opened a bugzilla for this: |
Got the the similar error:
|
I am also seeing the same with
|
FWIW I was able to move forward by stubbing out a junk status:
ingress:
- conditions:
- lastTransitionTime: "2019-12-06T03:24:58Z"
status: "True"
type: Admitted
host: <host>
routerCanonicalHostname: <host>
routerName: default
wildcardPolicy: None |
This is used to satisfy helm, workaround to bug: openshift/origin#24060
This is used to satisfy helm, workaround for bug openshift/origin#24060
I create a own helper inside
and at the end of a route I include the helper:
It reduce the amount of waste to a minimum |
Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(Route): missing required field "status" in com.github.openshift.api.route.v1. Route $ oc version Server https://ilocxxx-xxxx.xxxx.xxxx.com:8443 $ helm version |
If people want to be completely minimalist, this is the minimal
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
/lifecycle frozen |
/remove-lifecycle frozen |
The above workarounds are not useful if Helm chart is being used with a gitops tools such as ArgoCD. It continuously want to reconcile the |
The latest version of Openshift 3.11 should mark this field as optional References: |
@jkroepke We are using Openshift 3.10. Any chance that it could be back ported to that version? |
I guess no unless you want to build openshift from source. 3.10 is out of support. But an upgrade 3.11 should not be a problem. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When using Helm v3-rc.1, which includes OpenAPI validation before executing an install or upgrade, Route objects fail if they're missing optional fields (such as
spec.host
,status
,spec.to.weight
).After raising on the Helm Github (helm/helm#6830), I was pointed to the OKD v3.11 OpenAPI spec which incorrectly lists these fields as Required when, according to the Docs and API, they should be optional.
Version
Steps To Reproduce
templates/
dir>=v3.beta-5
, runhelm template ./my-chart-with-route --validate
(orhelm install ./my-chart-with-route
)Current Result
OKD v3.11 OpenAPI incorrectly lists some Optional fields as Required.
Expected Result
OKD v3.11 OpenAPI spec should list Required fields as Required and Optional fields as Optional.
Edit:
The text was updated successfully, but these errors were encountered: