-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: 30836: fix Dynamic provisioning for vSphere #11598
UPSTREAM: 30836: fix Dynamic provisioning for vSphere #11598
Conversation
is 30835 the right upstream PR? |
grr, my bad - the script (hack/cherry-pick.sh) generated that PR number and I thought it would be correct. fixing it. |
This PR does the following, Fixes an error 'A specified parameter was not correct:' occurs while dynamically provisioning the volumes. Adds VSAN support for dynamic provisioning.
9491b4e
to
4f196f0
Compare
[test] |
LGTM |
did you fix the numbers? |
I updated the PR title, but I still see it in the commit message |
There is some problem with github or something else. I did amend the commit and also changed the PR title - as you can see from multiple PR change "events" logged in this PR. Are you still seeing commit message to be wrong? I can see correct PR number in commit message. |
Evaluated for origin test up to 4f196f0 |
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10800/) (Base Commit: 90c7b56) |
I am not sure if this merge is sufficient, there is another one |
Yes, Ritesh mentioned he would be submitting another PR today. On Fri, Oct 28, 2016 at 12:48 PM, Huamin Chen notifications@github.com
|
yes, #11574 On Fri, Oct 28, 2016 at 1:37 PM, Hemant Kumar notifications@github.com
|
per email with dan [merge] |
Flaked on #10773 |
flake #10773 |
Flaked on #11661 |
[merge] |
Evaluated for origin merge up to 4f196f0 |
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10934/) (Base Commit: 0240260) (Image: devenv-rhel7_5290) |
This PR does the following,
Fixes an error 'A specified parameter was not correct:' occurs while dynamically provisioning the volumes.
Adds VSAN support for dynamic provisioning.