Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 30836: fix Dynamic provisioning for vSphere #11598

Merged

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Oct 26, 2016

This PR does the following,

Fixes an error 'A specified parameter was not correct:' occurs while dynamically provisioning the volumes.
Adds VSAN support for dynamic provisioning.

@rootfs
Copy link
Member

rootfs commented Oct 26, 2016

is 30835 the right upstream PR?

@gnufied
Copy link
Member Author

gnufied commented Oct 26, 2016

grr, my bad - the script (hack/cherry-pick.sh) generated that PR number and I thought it would be correct. fixing it.

This PR does the following,

Fixes an error 'A specified parameter was not correct:' occurs while dynamically provisioning the volumes.
Adds VSAN support for dynamic provisioning.
@gnufied gnufied force-pushed the fix-vsphere_dynamic_proviosioning branch from 9491b4e to 4f196f0 Compare October 26, 2016 20:46
@gnufied gnufied changed the title UPSTREAM: 30835: fix Dynamic provisioning for vSphere UPSTREAM: 30836: fix Dynamic provisioning for vSphere Oct 26, 2016
@childsb
Copy link
Contributor

childsb commented Oct 27, 2016

[test]

@childsb childsb added this to the 1.4.0 milestone Oct 27, 2016
@gnufied
Copy link
Member Author

gnufied commented Oct 27, 2016

It is flaking on #11094 and #11560

@erinboyd
Copy link

LGTM

@eparis
Copy link
Member

eparis commented Oct 27, 2016

did you fix the numbers?

@eparis eparis changed the title UPSTREAM: 30836: fix Dynamic provisioning for vSphere UPSTREAM: 30835: fix Dynamic provisioning for vSphere Oct 27, 2016
@eparis
Copy link
Member

eparis commented Oct 27, 2016

I updated the PR title, but I still see it in the commit message

@gnufied gnufied changed the title UPSTREAM: 30835: fix Dynamic provisioning for vSphere UPSTREAM: 30836: fix Dynamic provisioning for vSphere Oct 27, 2016
@gnufied
Copy link
Member Author

gnufied commented Oct 27, 2016

There is some problem with github or something else. I did amend the commit and also changed the PR title - as you can see from multiple PR change "events" logged in this PR. Are you still seeing commit message to be wrong? I can see correct PR number in commit message.

@erinboyd
Copy link

@childsb @rootfs Can one of you please help us. It's critical this gets merged

@childsb
Copy link
Contributor

childsb commented Oct 28, 2016

Flake #11094
Flake #11560
[test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 4f196f0

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10800/) (Base Commit: 90c7b56)

@rootfs
Copy link
Member

rootfs commented Oct 28, 2016

I am not sure if this merge is sufficient, there is another one
kubernetes/kubernetes#34997

@erinboyd
Copy link

Yes, Ritesh mentioned he would be submitting another PR today.
I was aware of it.
We will need to cherry pick it as well.
Erin

On Fri, Oct 28, 2016 at 12:48 PM, Huamin Chen notifications@github.com
wrote:

I am not sure if this merge is sufficient, there is another one
kubernetes/kubernetes#34997
kubernetes/kubernetes#34997


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11598 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADLTZ5glWDjSGyhIUVXRx0bqa7wrAVI9ks5q4kNwgaJpZM4KhmWw
.

@gnufied
Copy link
Member Author

gnufied commented Oct 28, 2016

@rootfs that PR has been already merged into origin master - #11574

@erinboyd
Copy link

yes, #11574

On Fri, Oct 28, 2016 at 1:37 PM, Hemant Kumar notifications@github.com
wrote:

@rootfs https://github.com/rootfs that PR has been already merged into
origin master.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#11598 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADLTZ_ImzIw0rxjm-KGijeatcLou94Inks5q4k8UgaJpZM4KhmWw
.

@childsb
Copy link
Contributor

childsb commented Oct 31, 2016

per email with dan

[merge]

@gnufied
Copy link
Member Author

gnufied commented Oct 31, 2016

Flaked on #10773

@childsb
Copy link
Contributor

childsb commented Oct 31, 2016

flake #10773
[merge]

@gnufied
Copy link
Member Author

gnufied commented Nov 1, 2016

Flaked on #11661

@childsb
Copy link
Contributor

childsb commented Nov 1, 2016

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 4f196f0

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 1, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/10934/) (Base Commit: 0240260) (Image: devenv-rhel7_5290)

@openshift-bot openshift-bot merged commit f55922e into openshift:master Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants