Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiple go versions #1192

Merged
merged 1 commit into from
Feb 28, 2015
Merged

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Feb 28, 2015

No description provided.

@bparees
Copy link
Contributor Author

bparees commented Feb 28, 2015

[test]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1212/)

@bparees
Copy link
Contributor Author

bparees commented Feb 28, 2015

@smarterclayton ptal.

@@ -70,7 +70,8 @@ func main() {
continue
}
// ignore non code segments
if match[2] != "T" {
//fmt.Println(line)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the println inside - debugging for someone later

@bparees bparees force-pushed the integration branch 2 times, most recently from 81b8217 to 2dce0f0 Compare February 28, 2015 05:50
@bparees
Copy link
Contributor Author

bparees commented Feb 28, 2015

not sure what you mean...you want to leave the println live?

@smarterclayton
Copy link
Contributor

The diff is showing it outside the if, vs in

On Feb 28, 2015, at 12:50 AM, Ben Parees notifications@github.com wrote:

not sure what you mean...you want to leave the println live?


Reply to this email directly or view it on GitHub.

@bparees
Copy link
Contributor Author

bparees commented Feb 28, 2015

yeah but it was also commented out. I hadn't even meant to leave it in the commit. the debug value was to print the lines before they got filtered away.

anyway i've put it back in commented out. merge?

@smarterclayton
Copy link
Contributor

LGTM [merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1079/) (Image: devenv-fedora_936)

@ncdc
Copy link
Contributor

ncdc commented Feb 28, 2015

Nice :-)

I also have a patch for starting etcd once we move to 2.0 (which I needed in addition to this when doing some recent integration test runs locally).

@bparees
Copy link
Contributor Author

bparees commented Feb 28, 2015

@mfojtik @soltysh looks like the race condition is still happening: https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1078/consoleFull (search for FAIL: TestSimpleImageChangeBuildTrigger)

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin up to 9d045f6

@bparees
Copy link
Contributor Author

bparees commented Feb 28, 2015

@smarterclayton btw it kinda bothers me that if golang changes their internals again, it's possible we'll stop running all the integration tests with no indication that has happened. maybe we need to add some logic to check if zero tests were run and if so, fail the run.

openshift-bot pushed a commit that referenced this pull request Feb 28, 2015
@openshift-bot openshift-bot merged commit d38ff43 into openshift:master Feb 28, 2015
@smarterclayton
Copy link
Contributor

Yes, good idea. Also, I need to print a separator for each test so you can see what's happening (in the script).

On Feb 28, 2015, at 1:24 PM, Ben Parees notifications@github.com wrote:

@smarterclayton btw it kinda bothers me that if golang changes their internals again, it's possible we'll stop running all the integration tests with no indication that has happened. maybe we need to add some logic to check if zero tests were run and if so, fail the run.


Reply to this email directly or view it on GitHub.

@smarterclayton
Copy link
Contributor

Someone definitely needs to get to the bottom of this. Either it's in the controller (very bad) or its in the test (which seems unlikely given that people have looked at it).

On Feb 28, 2015, at 1:08 PM, Ben Parees notifications@github.com wrote:

@mfojtik @soltysh looks like the race condition is still happening: https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1078/consoleFull (search for FAIL: TestSimpleImageChangeBuildTrigger)

[merge]


Reply to this email directly or view it on GitHub.

@bparees bparees deleted the integration branch March 5, 2015 15:28
jboyd01 pushed a commit to jboyd01/origin that referenced this pull request Sep 14, 2017
…service-catalog/' changes from ef63307bdb..ae6b643caf

ae6b643caf Use oc adm instead of oadm which might not exist in various installations.
66a4eb2a2c Update instructions... will remove once documented elsewhere
1b704d1530 replace build context setup with init containers
ee4df18c7f hack/lib: dedup os::util::host_platform and os::build::host_platform
1cd6dfa998 origin: Switch out owners to Red Hatters
664f4d318f Add instructions for syncing repos
2f2cdd546b origin-build: delete files with colon in them
cdf8b12848 origin-build: don't build user-broker
ebfede9056 origin build: add _output to .gitignore
55412c7e3d origin build: make build-go and build-cross work
68c74ff4ae origin build: modify hard coded path
3d41a217f6 origin build: add origin tooling
a8fc27d Fix typos in walkthrough  (openshift#1224)
e77edbf openshift#1157: Limit the amount of time for reconciliations (openshift#1196)
1b1a749 temporarily disabled verify-links.sh from the verify target (openshift#1226)
acf8fab Send originating identity headers in OSB requests (openshift#1162)
821ba16 new admission controller to block updates to service instance updates that (openshift#1210)
d69c5e5 Minor improvement to godoc in binaries (openshift#1211)
5b81814 fix typos (openshift#1221)
836dc4a Adds how to download Helm chart (charts/catalog) (openshift#1219)
2fd0115 Fix "visit the project on github" link. (openshift#1217)
325e4b6 Add how to set $GOPATH. (openshift#1218)
68b775f Update the installation (openshift#1199)
6e3a3c1 v0.0.19 (openshift#1207)
8b69791 Removing errexit from TLS setup script (openshift#1206)
273260f Instance deletion lifecycle enhancements, issue openshift#820 (openshift#1159)
c050713 fix cleaning of build output for non-root users (openshift#1205)
5995df1 Merge branch 'pr/1204'
72f4802 Remove osb prefix from example ServiceClass (openshift#1201)
f9dbd4e pin all dependencies in glide to current version except for glog where we want to pick up the prior version to fix issue 1187.
f148bc5 v0.0.18 (openshift#1202)
b86ab8d Removing the helm install command (openshift#1185)
3cff482 Remove Alpha* prefix on all API fields for issue openshift#1180 (openshift#1184)
154b74d Fix gofmt issue (openshift#1192)
2ee894a do the clean before building an arch (openshift#1179)
b4976ef Fix bad URL (openshift#1189)
cd3dede Fix hrefs again (openshift#1190)
f066226 Design: Instance/Binding parameters (openshift#1075)
eb37682 This generated file is missing from master (openshift#1191)
28c0ae7 Use generation instead of checksum for Instances and InstanceCredentials (openshift#1151)
5cdd323 Fix bad href (openshift#1188)
8a892f0 handle lingering polling cases (openshift#1174)
f5fabd6 remove TPRs from Jenkins e2e pipeline (openshift#1175)
717df78 Add godoc explaining that Instance and InstanceCredential specs are immutable (openshift#1182)
REVERT: ef63307bdb origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: ae6b643cafd3a17412f173e70ed7c1a2e39ee549
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Feb 1, 2018
When running "make verify" I see this:
```
Running gofmt:
Running golint and go vet:
pkg/apis/servicecatalog/checksum/checksum_test.go
```

What's odd is that the file name is due to the gofmt not the golint.
But, the real issues are:
1) the `&>` in the Makefile isn't getting picked up
2) the gofmt issue

This PR replaces `&>` with `> .out 2>&1`.
I don't need to fix that file any more because its been removed.

Signed-off-by: Doug Davis <dug@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants